Fix MSVC FTBFS#490
Merged
floe merged 1 commit intoOpenKinect:masterfrom Dec 3, 2015
xlz:msvc-symbol-resolving
Merged
Conversation
The workaround broke MSVC building. MSVC refuses to resolve the symbol because the return type is different, which was the point of the workaround. Alternative workarounds would make it more a mess. I have sent a patch to iai_kinect2 directly to use new API.
Contributor
|
This also fixes an issue with generating SWIG code on master in #427 👍 |
Contributor
|
@RyanGordon great, so did you also test this on MSVC? Then I think I'll merge it right away, multiple inheritance is actually a big problem with SWIG IIRC, so good to get rid of it. |
Contributor
|
@floe Unfortunately, I don't have MSVC setup to test this |
Member
Author
|
#489 user reported this worked on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workaround cdd4f06 (from #476) broke MSVC building (reported in #489). I didn't test MSVC in #476. MSVC refuses to resolve the symbol because the return type is different, which was the point of the workaround.
Alternative workarounds would make it more a mess. I have sent a patch to iai_kinect2 directly to use new API. code-iai/iai_kinect2#189
Build tested OK with MSVC and GCC after this PR.